Fix "Number 45: Crumble Logos the Prophet of Demolition" #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the following changes to the script: - Added registration of EFFECT_DISABLE_TRAPMONSTER effect to the target ---> Trap Monsters (that were still treated as Traps) in the Monster Zone did not return to the Spell & Trap Zone after their effects were negated by Logos. - Changed Card.IsFaceup with Card.IsNegatable for the target selection ---> Logos' effect could be activated by targeting a card whose effects had already been negated. The latter constitutes an invalid target according to the cited ruling (https://db.ygoresources.com/qa#19306) - Added a Card.IsFaceup check for the handler at resolution ---> If Logos' became face-down at the time of the resolution of its effect, the negation would still go through. This should not happen according to https://db.ygoresources.com/qa#7034 I could not find a reference for whether a Trap Monster (that returned to the Spell & Trap Zone after being negated by Logos) keeps being "targeted" by it even while in the backrow, so I did not change anything in that regard and kept the Card.SetCardTarget approach, which makes Logos lose the target once it is moved from the Monster Zone to the Spell & Trap Zone.
|
As for the replays, I tried opening a forum post on the Discord but I think the bot timed me out because of the ruling links that were present in the message(?)... One of the issues mentioned in the list (the one about Trap Monsters) was already reported in an older forum post I wrote: https://discord.com/channels/170601678658076672/1335078163814023258 I'll upload the replays here for the time being: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the following changes to the script:
I could not find a reference for whether a Trap Monster (that returned to the Spell & Trap Zone after being negated by Logos) keeps being "targeted" by it even while in the backrow, so I did not change anything in that regard and kept the Card.SetCardTarget approach, which makes Logos lose the target once it is moved from the Monster Zone to the Spell & Trap Zone.