Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing "Darkness" scripts #204

Merged
merged 41 commits into from
Apr 22, 2020
Merged

Add missing "Darkness" scripts #204

merged 41 commits into from
Apr 22, 2020

Conversation

AlphaKretin
Copy link
Contributor

@AlphaKretin AlphaKretin commented Apr 20, 2020 •
edited
Loading

As of the first commit, these are in the same state they last were in Percy before removal and need much cleanup. This is a draft PR intended to be used to track the state of work on restoring them. Related to #110.

Cards to clean up/rescript:

  • c511310100.lua Darkness
  • c511310101.lua Darkness 1
  • c511310102.lua Darkness 2
  • c511310103.lua Darkness 3
  • c511310104.lua Zero
  • c511310105.lua Infinity
  • c511310106.lua Darkness Seed
  • c511310107.lua Darkness Bramble
  • c511310108.lua Darkness Raincrow
  • c511310109.lua Darkness Eye
  • c511310110.lua Darkness Outsider
  • c511310111.lua Darkness Slime
  • c511310112.lua Darkness Necroslime
  • c511310113.lua Darkness Neosphere (Anime)

Cards to test:

  • c511310100.lua Darkness
  • c511310101.lua Darkness 1
  • c511310102.lua Darkness 2
  • c511310103.lua Darkness 3
  • c511310104.lua Zero
  • c511310105.lua Infinity
  • c511310106.lua Darkness Seed
  • c511310107.lua Darkness Bramble
  • c511310108.lua Darkness Raincrow
  • c511310109.lua Darkness Eye
  • c511310110.lua Darkness Outsider
  • c511310111.lua Darkness Slime
  • c511310112.lua Darkness Necroslime
  • c511310113.lua Darkness Neosphere (Anime)

@AlphaKretin
Add missing "Darkness" scripts
a338a9c 
In state from Percy, requires much cleanup
@AlphaKretin AlphaKretin added help wanted Mechanical changes to lots of scripts for better code quality draft WIP, don't merge (use draft PRs instead of this label!) unofficial Illegal, anime, manga, video game labels Apr 20, 2020
@AlphaKretin AlphaKretin self-assigned this Apr 20, 2020
@AlphaKretin AlphaKretin marked this pull request as draft April 20, 2020 07:02
@AlphaKretin AlphaKretin mentioned this pull request Apr 20, 2020
Open
15 tasks
@AlphaKretin AlphaKretin removed the help wanted Mechanical changes to lots of scripts for better code quality label Apr 20, 2020
@AlphaKretin
Copy link
Contributor Author

Basic concept for Darkness 1,2 and 3 scripts:
Can activate at any time, but if not activated by Zero/Infinity, does nothing. If they have, if they're Chain Link 1, they do their thing and count how many Darkness cards were higher Chain Link. If they're higher than Chain Link 1, they set a flag for CL1 to count.

In my opinion this best reflects the intersection of the text and their anime behaviour

@AlphaKretin

This comment has been minimized.

Sign in to view
@AlphaKretin
Update "Zero" and "Infinity"
6c68456 
Activate cards outside of chains
@AlphaKretin
Fix "Zero" and "Infinity"
2fccc59 
Typo
@AlphaKretin
Re-ID to AlphaKretin's range
a2acfd3 
Agreed upon with Larry, where they end up is less important than getting them out of 100-.
@AlphaKretin
Update IDs in cards already updated
7c3c1e0
@AlphaKretin
Copy link
Contributor Author

Duel.SelectMatchingCard overrides EFFECT_DARKNESS_HIDE. This is a double-edged sword: It gives us a convenient way for Darkness Eye to view the set cards, but it makes blindly selecting them with Zero and Infinity awkward.

@AlphaKretin
Update "Darkness"
1c2a3a7 
Set cards even if nothing is destroyed
@AlphaKretin
Rescript "Darkness Eye"
c6481e2
@AlphaKretin
Partial progress on Zero/Infinity rework
3382170 
Select zone, not card, so that name isn't shown under DARKNESS_HIDE
@AlphaKretin
Update "Zero" and "Infinity" first effect
d81bf54 
Working selection without revealing card name. Second effect still to go.
@AlphaKretin
Fix typos in "Zero" and "Infinity" second effect
a67616f 
Not fully working yet, does not activate multiple cards in the same chain
@AlphaKretin
Update "Zero", "Infinity", "Darkness 1-3"
3529ffd 
New solutions for activation. Zero and Infinity activating each other apply at `EVENT_CHAIN_END` for smoother experience, Darkness 1-3 get flipped up by Zero or Infinity and then Trigger on a custom event. Also made Zero and Infinity once per chain and fixed a variety of typos in all cards.
@AlphaKretin
Fix "Darkness"
dc70a60 
Shuffles the set cards when first placed.
@AlphaKretin
Clean up "Darkness Bramble"
062dbd2
@AlphaKretin
Update "Darkness Raincrow"
eeb822f
@AlphaKretin
Clean up "Darkness Outsider"
aba8911
@AlphaKretin
Update "Darkness Necroslime"
d347ca1 
Should use c420 instead of hardcoding its own list. c420 will need updating.
@AlphaKretin
Copy link
Contributor Author

c420 will need an update to include Card.IsDarkness. I'm discussing with @larry126 whether that should occur in this branch for ease of testing, or as part of his own ongoing rework of c420.

@AlphaKretin
Rescript "Darkness Neosphere" (partial)
c6bfc07 
2nd effect not yet scripted
@AlphaKretin
Add "Darkness" archetype (incomplete)
ff7c46f 
@larry216 is currently researching all necessary archetype members
@AlphaKretin
Fix "Darkness 1-3"
8b5f949 
Forced activations should be... forced
@AlphaKretin
Style updates per .editorconfig
b364f20
@AlphaKretin
Update "Darkness" archetype
47094a2
@AlphaKretin
Update "Darkness Neosphere"
e39000c 
Finish last effect to rearrange set cards
@AlphaKretin
Updates for strings
f2e9ec5
@AlphaKretin
Fix "Darkness Neosphere (anime)"
21cd721 
Does not specify a summon method
Typo in effect to turn a card face-down
@AlphaKretin AlphaKretin marked this pull request as ready for review April 22, 2020 06:30
@AlphaKretin
Copy link
Contributor Author

AlphaKretin commented Apr 22, 2020 •
edited
Loading

I've finished all the scripts to my personal satisfaction. All cards and effects are implemented and I've tested them for functionality. Database entries will need to be added at the same time this is merged. A database with everything but categories can be found here, but note that some entries for Darkness cards with old IDs will need to be removed from current databases:

  • Darkness Seed: 100000700
  • Darkness Outsider: 100000704
  • Darkness Slime: 100000705
  • Darkness Necroslime: 100000706

@AlphaKretin AlphaKretin added enhancement New feature or request and removed draft WIP, don't merge (use draft PRs instead of this label!) labels Apr 22, 2020
larry126 and others added 3 commits April 22, 2020 19:21
@larry126
Indentation fix
320feb4
@AlphaKretin
Update "Darkness Neosphere (anime)"
3c82ea7 
Because Darkness used it on Judai's turn, the effect to rearrange all Spell/Traps must be a Quick Effect.
@AlphaKretin
Merge remote-tracking branch 'origin/darkness' into darkness
df4ceab
larry126
larry126 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@larry126 larry126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done reviewing, no problem. Preparing CDB atm.

@larry126 larry126 merged commit 92d3e03 into master Apr 22, 2020
@larry126 larry126 deleted the darkness branch April 22, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larry126 larry126 larry126 approved these changes

Assignees

@AlphaKretin AlphaKretin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlphaKretin @larry126