BSO outer wear pocket parity

[MallowSune]

About the PR

The following outer clothing now features a 2x3 storage:

• Blueshield's Security Armor (ClothingBlueshieldArmourVest)
• Blueshield's Armored Jacket (ClothingBlueshieldArmoredJacket)
• Blueshield's Armored Cowboy Jacket (ClothingBlueshieldArmoredCowboyJacket)
• Blueshield's Armored Marine Vest (ClothingBlueshieldArmoredMarine
• Blueshield's Armored Vest (ClothingBlueshieldArmoredVest)
• Blueshield's Armored Kimono (ClothingOuterBlueshieldArmourKimono)

Why / Balance

Prior to this PR, only the Blueshield's Armored Coat and the Blueshield's Armored Winter Coat have pockets. This PR aims to give parity to the rest of the BSO outer clothing to allow more freedom of expression in what BSO players choose to wear.

Technical details

Added 'ClothingOuterStorageBase' to ClothingBlueshieldArmourVest, adding storage to all BSO outer wear.

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• tweak: All BSO outer wear on loadout selection now features a 2x3 inventory. Stash your smokes no matter how you choose to look while blueshielding!

[MallowSune]

This is my first PR ever please be nice 🙏

[3PonPon3]

Two things

1. Almost all the bso outer options parent off of the base bso armour vest - adding the ClothingOuterStorageBase parent to that entity will automatically apply to the rest as they parent off of it
2. Did you test it in your dev env just to be sure? It's good practice to test even small changes like this, and also to get media for the PR so whichever maint looks over it can see you checked it

[3PonPon3]

Two things

1. Almost all the bso outer options parent off of the base bso armour vest - adding the ClothingOuterStorageBase parent to that entity will automatically apply to the rest as they parent off of it
2. Did you test it in your dev env just to be sure? It's good practice to test even small changes like this, and also to get media for the PR so whichever maint looks over it can see you checked it

[3PonPon3]

That sent twice for some reason

[MallowSune]

Two things

1. Almost all the bso outer options parent off of the base bso armour vest - adding the ClothingOuterStorageBase parent to that entity will automatically apply to the rest as they parent off of it
2. Did you test it in your dev env just to be sure? It's good practice to test even small changes like this, and also to get media for the PR so whichever maint looks over it can see you checked it

1. Ah good to know, will keep that in mind in the future.
2. Yes I did test this and all the clothes did have the intended inventory.

[3PonPon3]

Then fyi it's best to take screenshots when you test it to post in the "media" part of the PR ^^

[MallowSune]

Alright cleaned up those parents, and updated PR with screenshots.

[NotActuallyMarty]

I'm fine with giving the other things pockets, However the main vest should stay without them. The way the coats are balanced is that the coats have slightly weaker armor, in exchange for those pockets and some cold protection for the winter coats.

You should reparent the other outerwear to the blueshield armored coat instead to give them pockets, while the regular armor vest should in my opinion stay pocketless.

[NotActuallyMarty]

When changing something that is from upstream (in this case an edit in a file under _Goobstation) Mark it with a comment so that we are aware that this change is made on our end. Otherwise it is exceedingly likely to get reverted by accident as a change if upstream ever touches this file.

You would do so like this, adding a # for a comment in yaml.

Suggested change

	parent: [ BaseCentcommContraband, ClothingOuterArmorCaptainCarapace, ClothingOuterStorageBase ]
	parent: [ BaseCentcommContraband, ClothingOuterArmorCaptainCarapace, ClothingOuterStorageBase ] # Omu

[NotActuallyMarty]

Though now that I've added this requested change i realise that it is obsolete due to the things mentioned above. Oh well, make note of this if you get to acting on requested changes.

[3PonPon3]

I'm fine with giving the other things pockets, However the main vest should stay without them. The way the coats are balanced is that the coats have slightly weaker armor, in exchange for those pockets and some cold protection for the winter coats.

You should reparent the other outerwear to the blueshield armored coat instead to give them pockets, while the regular armor vest should in my opinion stay pocketless.

Thing is, they ALL have the same armor EXCEPT the winter coat. The winter coat is the only one with different armor values, as it parents off of cap's winter coat, and the rest of the outerwear options parent off of the base vest BSO gets, which in turn parents from cap's carapace.

So like, it's fine imo.

[Lamission877]

I'm fine with giving the other things pockets, However the main vest should stay without them. The way the coats are balanced is that the coats have slightly weaker armor, in exchange for those pockets and some cold protection for the winter coats.
You should reparent the other outerwear to the blueshield armored coat instead to give them pockets, while the regular armor vest should in my opinion stay pocketless.

Thing is, they ALL have the same armor EXCEPT the winter coat. The winter coat is the only one with different armor values, as it parents off of cap's winter coat, and the rest of the outerwear options parent off of the base vest BSO gets, which in turn parents from cap's carapace.

So like, it's fine imo.

Consider, Cap's jacket has a decrease of 5% across the board for those pocket slots.

[3PonPon3]

I'm fine with giving the other things pockets, However the main vest should stay without them. The way the coats are balanced is that the coats have slightly weaker armor, in exchange for those pockets and some cold protection for the winter coats.

You should reparent the other outerwear to the blueshield armored coat instead to give them pockets, while the regular armor vest should in my opinion stay pocketless.

Thing is, they ALL have the same armor EXCEPT the winter coat. The winter coat is the only one with different armor values, as it parents off of cap's winter coat, and the rest of the outerwear options parent off of the base vest BSO gets, which in turn parents from cap's carapace.

So like, it's fine imo.

Consider, Cap's jacket has a decrease of 5% across the board for those pocket slots.

Wow I somehow never noticed! But BSO's things still all parent off of the carapace excluding the winter coat...

[github-actions]

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our development discord.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.