Skip to content

Commit

Permalink
add a clarification about event data copying
Browse files Browse the repository at this point in the history
  • Loading branch information
0age committed Feb 27, 2024
1 parent f217574 commit 72e8e96
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/core/lib/ConsiderationEncoder.sol
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,9 @@ contract ConsiderationEncoder {

/**
* @dev Takes an order hash and BasicOrderParameters struct (from calldata)
* and encodes it as `authorizeOrder` calldata.
* and encodes it as `authorizeOrder` calldata. Note that data is
* copied from event data, so this function will need to be modified if

This comment has been minimized.

Copy link
@Saw-mon-and-Natalie

Saw-mon-and-Natalie Mar 7, 2024

Collaborator

Not copied anymore.

This comment has been minimized.

Copy link
@Saw-mon-and-Natalie

Saw-mon-and-Natalie Mar 7, 2024

Collaborator

but fixed in the other PR.

* the layout of that event data changes.
*
* @param orderHash The order hash.
*
Expand Down

0 comments on commit 72e8e96

Please sign in to comment.