Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seaport 1.6 #1305

Merged
merged 45 commits into from
Mar 18, 2024
Merged

Seaport 1.6 #1305

merged 45 commits into from
Mar 18, 2024

Conversation

0age
Copy link
Contributor

@0age 0age commented Mar 7, 2024

This PR brings over Seaport 1.6 development from https://github.com/ProjectOpenSea/seaport-1.6 — the most significant change is the addition of a new authorizeOrder pre-hook call on restricted orders prior to execution.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 81.76796% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 97.26%. Comparing base (4f4e7c2) to head (26ac0e9).

Files Patch % Lines
reference/lib/ReferenceZoneInteraction.sol 50.00% 6 Missing and 4 partials ⚠️
reference/lib/ReferenceOrderCombiner.sol 84.21% 6 Missing and 3 partials ⚠️
reference/lib/ReferenceOrderValidator.sol 86.00% 4 Missing and 3 partials ⚠️
reference/lib/ReferenceCriteriaResolution.sol 50.00% 0 Missing and 6 partials ⚠️
reference/lib/ReferenceFulfillmentApplier.sol 83.33% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
- Coverage   99.77%   97.26%   -2.52%     
==========================================
  Files          22       21       -1     
  Lines        1363     1279      -84     
  Branches      220      248      +28     
==========================================
- Hits         1360     1244     -116     
- Misses          3       16      +13     
- Partials        0       19      +19     
Flag Coverage Δ
foundry ?
production ?
reference 97.26% <81.76%> (-2.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0age 0age marked this pull request as ready for review March 18, 2024 17:12
@0age 0age merged commit b8d4f10 into main Mar 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants