Skip to content

refactor: remove duplicated mips_costs parsing logic in Executor constructorc #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eigmax merged 3 commits into from
Feb 14, 2026
Merged

refactor: remove duplicated mips_costs parsing logic in Executor constructorc #447

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d59b127
Update executor.rs
letmehateu Feb 13, 2026
6c4bb60
Update executor.rs
letmehateu Feb 13, 2026
a4eae2d
fmt
letmehateu Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions crates/core/executor/src/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use std::{
fs::File,
io::{BufWriter, Write},
str::FromStr,
sync::Arc,
};

Expand Down Expand Up @@ -40,10 +39,6 @@ use crate::{
/// The maximum number of instructions in a program.
pub const MAX_PROGRAM_SIZE: usize = 1 << 22;

/// The costs for the airs.
pub const MIPS_COSTS: &str = include_str!("./artifacts/mips_costs.json");

/// Whether to verify deferred proofs during execution.
/// The default increment for the program counter. Is used for all instructions except
/// for branches and jumps.
pub const DEFAULT_PC_INC: u32 = 4;
Expand Down Expand Up @@ -305,9 +300,7 @@ impl<'a> Executor<'a> {

let hook_registry = context.hook_registry.unwrap_or_default();

let costs: HashMap<String, usize> = serde_json::from_str(MIPS_COSTS).unwrap();
let costs: HashMap<MipsAirId, usize> =
costs.into_iter().map(|(k, v)| (MipsAirId::from_str(&k).unwrap(), v)).collect();
let costs = crate::mips_costs();

Self {
record,
Expand Down