perf: avoid unnecessary clones for executor input streams#69
Open
VolodymyrBg wants to merge 1 commit intoProjectZKM:mainfrom
Open
perf: avoid unnecessary clones for executor input streams#69VolodymyrBg wants to merge 1 commit intoProjectZKM:mainfrom
VolodymyrBg wants to merge 1 commit intoProjectZKM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes redundant clone() calls for public, private and receipt input buffers in Executor::split. We already own the Vec values returned from file::read and deserialization, and State::input_stream takes ownership of Vec, so cloning only increases memory usage and copy time without any benefit.
While touching this area, I also stopped cloning segment and ELF paths where simple &str borrowing is sufficient. This reduces a few extra heap allocations for String and keeps the API usage closer to how the emulator’s State is implemented.