Backward compatiblity with older redis versions #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drieschel
force-pushed
the
redis_backward_compatiblity
branch
from
36b2655
to
9407858
Compare
…with redis version < 5 Signed-off-by: Immanuel Klinkenberg <[email protected]>
Signed-off-by: Immanuel Klinkenberg <[email protected]>
drieschel
force-pushed
the
redis_backward_compatiblity
branch
from
9407858
to
ab3ba7a
Compare
Signed-off-by: Immanuel Klinkenberg <[email protected]>
drieschel
force-pushed
the
redis_backward_compatiblity
branch
from
31eb85e
to
7350e5f
Compare
|
Will it work when another redis version to the |
|
@LKaemmerling Do you miss something here? Would be great if we can have an open conversation about this MR. Would love to see it merged soon. Our metrics are growing and it is actually not possible to reset the counters on application level for us. |
|
Sorry for the late reply, i'm actually quite busy and the only one who tries to look over this.
@drieschel yes this should work. You can try it. |
LKaemmerling
approved these changes
Nov 6, 2023
|
Thank you! |
|
Thanks to you @LKaemmerling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR adds backward compatiblity with redis versions lower 5. Wiping the redis storage did not work without the added command
redis.replicate_commands().According to the redis documentation this command is deprecated in redis 7 but it still exists for backward compatiblity with older redis versions (see here).
We are using a redis 4 cluster and cannot upgrade it easily. So this MR helps us to get this component running without changing it externally.
Also others seem to have the same problem, ie #130 .