reliably detect coqdep errors for 8.19 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 3 tests to check that coqdep errors are reliably detected, see also issue ProofGeneral#722. Two of them are expected to fail for 8.19, because coqdep output changed in that version.
Add user option coq-compile-coqdep-warnings to configure warnings for Coq 8.19 or later. The default value +module-not-found ensures Proof General reliably detects missing modules via a coqdep error. This changes kinds of supersedes the earlier commit 36b1d28 that adapts the coqdep warning regexp.
hendriktews
changed the title
|
Fixes #722 . |
erikmd
approved these changes
Jan 7, 2024
There was a problem hiding this comment.
LGTM! Thanks a lot @hendriktews, for your thorough analysis and bugfix with accompanying tests 👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3 tests to check that coqdep errors are reliably detected, see also issue #722. Two of them are expected to fail for 8.19, because coqdep output changed in that version.