fix(events): collapse rsvp picker into single button - #1135
Merged
Conversation
Replace the 3-button going/maybe/can't-go picker on the event detail page with one 'rsvp' button that opens the same RsvpBox modal, since the modal already lets you pick a status. The already-RSVP'd state (single status/edit button) is unchanged. Also drops the now-unused 'prominent' prop from RsvpStatusPicker.
rsvp-member.spec.ts and live-updates.spec.ts still clicked "i'm going", the old 3-button picker's label. The member RsvpSection's primary action button is now a single "rsvp" button (or "join the waitlist" at capacity); rsvp-public-* specs are unaffected since they go through PublicRsvpForm/RsvpStatusPicker, a separate component this PR didn't touch.
leahpeker
marked this pull request as ready for review
July 24, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RsvpBoxmodal (which already lets you pick going/maybe/can't go/waitlist).prominentprop fromRsvpStatusPicker(only consumer was the removed 3-button row);RsvpStatusPickeritself is still used insideRsvpBoxandPublicRsvpForm.References Issue 1133.
Test plan
make agent-frontend-typecheck— cleanmake agent-frontend-lint— cleanRsvpSection.test.tsx,RsvpStatusPicker.test.tsx,RsvpBox.test.tsx,PublicRsvpForm.test.tsx— 72/72 passedmake agent-ciintentionally skipped per task instructions