Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#28738 gave me the idea that we don't have a linter yet, like clippy for rust, that can be used to check for common coding patterns by teams in codebases.
This pr gives a linting framework, a linter, and a way to provide a collection of standard lints for leo or a leo package to standardize the coding practices across different leo packages / teams and check for common mistakes, potential fallouts between leo and snarkVM etc.
Inspirations for the design were mainly taken from rust's clippy, aptos's move language linter, cairo's linter.
note: most of the lints can be done early, but I prefer late when possible for two reasons, one being easier to traverse the tree and implementation and second is clear decoupling / separation of intentions, where early can be only used for lints where late can't be.
Test Plan
Included testing module for the linter