-
Notifications
You must be signed in to change notification settings - Fork 480
[Feature] Support for proof-less execution transactions (Leo Devnode suport) #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "name": "@provablehq/wasm", | ||
| "version": "0.9.11", | ||
|
|
||
| "type": "module", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to delete before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually needs to stay here :)
iamalwaysuncomfortable
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good and we should get this in, however it needs some changes.
- We absolutely need to remove the dev features as it'll make the SDK non-functional in production
- We should have different
ProgramManagermethods for dev node on second thought so that people know that these methods exist and we don't add any error to our existing methods.
| "name": "@provablehq/wasm", | ||
| "version": "0.9.11", | ||
|
|
||
| "type": "module", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually needs to stay here :)
Signed-off-by: Roy Rotstein <[email protected]>
Signed-off-by: Roy Rotstein <[email protected]>
iamalwaysuncomfortable
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits below, can we also make a create-leo-app example that shows how to deploy and execute a program against a devnode with a Readme.md that shows how to set it up?
sdk/src/program-manager.ts
Outdated
| * | ||
| * @example | ||
| * /// Import the mainnet version of the sdk. | ||
| * import { AleoKeyProvider, ProgramManager, NetworkRecordProvider } from "@provablehq/sdk/mainnet.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * import { AleoKeyProvider, ProgramManager, NetworkRecordProvider } from "@provablehq/sdk/mainnet.js"; | |
| * import { AleoKeyProvider, getOrInitConsensusVersionTestHeights, ProgramManager, NetworkRecordProvider } from "@provablehq/sdk/mainnet.js"; |
iamalwaysuncomfortable
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should refactor these methods to use some common routines to reduce code duplication as this will become harder to maintain in the future, but this is approved for now in order to provide the functionality to outside users.
Motivation
The Leo devnode tool enables developers to rapidly iterate on their Aleo programs without having to wait for proof generation when generating execution transactions. Many developers run CI tests in JS, so having support for generating proof-less execution transactions will enable developers to use the SDK to make transactions against the devnode server.
Test Plan
Tests will require Leo devnode to be installed.
leo devnode start --private-key $PRIVATE_KEY --verbosity 2This will initialize a development server at
http://localhost:3030.3. Navigate to
create-leo-app/template-devnode-js.Run
yarn devto run the example.Related PRs
Leo devnode PR:
ProvableHQ/leo#28982