fix: validateOnReuse incorrectly throws #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psibean
force-pushed
the
fix/validate-on-reuse-throws-incorrectly
branch
2 times, most recently
from
bdb7875 to
96251c7
Compare
Logic for validateOnReuse parameter is still incorrect. If validateOnReuse is false, overwrite is true, but the token from the cookie is invalid, this should silently fail and return a new valid token instead.
psibean
force-pushed
the
fix/validate-on-reuse-throws-incorrectly
branch
from
96251c7 to
0e2467a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic for
validateOnReuseparameter is still incorrect. IfvalidateOnReuseis false, overwrite is true, but the token from the cookie is invalid, this should silently fail and return a new valid token instead.