Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile species filter #298

Merged
merged 6 commits into from
Jun 11, 2020
Merged

Mobile species filter #298

merged 6 commits into from
Jun 11, 2020

Conversation

mrtmrt233
Copy link
Contributor

addresses #296

Mobile view now shows species search and locate button, hides address bar

@emillipede
Copy link
Collaborator

emillipede commented Jun 11, 2020

thank you @mrtmrt233

when I test it, the species buttons are kind of floating in the middle of the toolbar, and the select2 bar sometimes overlaps a little bit with the buttons (see screenshots). the toolbar is also quite tall, but that's a separate issue (#245 / #263)

is it difficult move the leaflet location button the bottom of the map (with the zoom in/out buttons)?

before (testing as iphoneX)
Screen Shot 2020-06-11 at 11 38 35 AM

after (testing as iphoneX)
Screen Shot 2020-06-11 at 11 38 10 AM
Screen Shot 2020-06-11 at 11 44 22 AM

@mrtmrt233
Copy link
Contributor Author

fixed (I think)

@emillipede
Copy link
Collaborator

emillipede commented Jun 11, 2020

thank you @mrtmrt233

will you please adjust the margins a little bit, so that the borders on each side of the toolbar look even?

do you know why the placeholder text inside the select2 bar is cut off (even though there's space left inside the bar, the E at the end of "name" isn't visible - see photo - I know that the long species names won't all fit in a mobile phone's window)? the same issue come up with the address search bar, but it wasn't resolved

before (testing as iphoneX):
Screen Shot 2020-06-11 at 1 41 53 PM

after (testing as iphoneX):
Screen Shot 2020-06-11 at 1 40 08 PM

Screen Shot 2020-06-11 at 1 41 39 PM

@emillipede emillipede merged commit e619c80 into master Jun 11, 2020
@mrtmrt233 mrtmrt233 mentioned this pull request Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants