-
-
Notifications
You must be signed in to change notification settings - Fork 318
Add Items with their corresponding entitys #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Joniii11
wants to merge
26
commits into
Pumpkin-MC:master
Choose a base branch
from
Joniii11:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce it was already existing oops
…StandEntity NBT handling
…ct cooldown and process thrown item entity
I would like some feedback from you guys if this is good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and improvements related to entity management, item behavior, and projectile mechanics, especially focusing on the addition of armor stand and wind charge entities and items. It also includes utility enhancements and some internal refactoring to support these features.
Entity and Item Additions:
pumpkin/src/entity/decoration/armor_stand.rs
,pumpkin/src/item/items/armor_stand.rs
,pumpkin/src/item/items/mod.rs
,pumpkin/src/item/items/mod.rs
,pumpkin/src/item/items/mod.rs
) [1] [2] [3] [4] [5]pumpkin/src/entity/projectile/wind_charge.rs
,pumpkin/src/entity/projectile/mod.rs
,pumpkin/src/item/items/wind_charge.rs
,pumpkin/src/item/items/mod.rs
,pumpkin/src/item/items/mod.rs
) [1] [2] [3] [4] [5]Projectile Mechanics and Utilities:
pumpkin/src/entity/projectile_deflection.rs
,pumpkin/src/entity/mod.rs
) [1] [2]invisible
flag and a method to set it. (pumpkin/src/entity/mod.rs
) [1] [2] [3]Math and Utility Improvements:
EulerAngle
struct for representing and serializing 3D rotations, and a utility method to compute the average side length of a bounding box. (pumpkin-util/src/math/euler_angle.rs
,pumpkin-util/src/math/mod.rs
,pumpkin-util/src/math/boundingbox.rs
) [1] [2] [3]Protocol and Serialization Fixes:
pumpkin-protocol/src/java/client/play/spawn_entity.rs
)Please follow our Coding Guidelines
Testing
So basically, just place down a armor stand, and throw a wind charge entity. The explosion on impact does not work yet, since there is no collision logic there yet.