feat: Implement EnderChest #1163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
HttpRafa
force-pushed
the
feat/ender-chest
branch
from
6702a0f to
c4f9282
Compare
Snowiiii
reviewed
Sep 14, 2025
| impl NBTStorageInit for PlayerInventory {} | ||
|
|
||
| #[async_trait] | ||
| impl NBTStorage for EnderChestInventory { |
There was a problem hiding this comment.
I don't think this should be inside the Player file
There was a problem hiding this comment.
Ok, should I put it in a separate module in the pumpkin crate?
There was a problem hiding this comment.
I think it's already in a good place cause it's in a way tied to the player inventory
There was a problem hiding this comment.
I think it's already in a good place cause it's in a way tied to the player inventory
I could move it under player/ender_chest_inventory.rs.
HttpRafa
force-pushed
the
feat/ender-chest
branch
from
c4f9282 to
a34bd42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the EnderChest block. For this functionality, it introduces the EnderChestInventory struct and a corresponding field. It also adds support for reading and writing the inventory through NBT functions. Additionally, this PR introduces the EnderChest block entity and includes other boilerplate code required for the block.
Testing
2025-09-01_19-40-57.mp4