-
Notifications
You must be signed in to change notification settings - Fork 48
Added remaining Heavensward FSH class quests #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShermTank7272
wants to merge
2
commits into
PunishXIV:new-main
Choose a base branch
from
ShermTank7272:heavensward-fsh
base: new-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+407
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
118 changes: 118 additions & 0 deletions
118
QuestPaths/3.x - Heavensward/Class Quests/FSH/2087_Invasion of the Supper Snatchers.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| { | ||
| "$schema": "https://qstxiv.github.io/schema/quest-v1.json", | ||
| "Author": "ShermTank", | ||
| "QuestSequence": [ | ||
| { | ||
| "Sequence": 0, | ||
| "Steps": [ | ||
| { | ||
| "DataId": 1013250, | ||
| "Position": { | ||
| "X": 100.35852, | ||
| "Y": 15.00001, | ||
| "Z": 24.307495 | ||
| }, | ||
| "TerritoryId": 418, | ||
| "InteractionType": "AcceptQuest", | ||
| "AetheryteShortcut": "Ishgard", | ||
| "AethernetShortcut": [ | ||
| "[Ishgard] Aetheryte Plaza", | ||
| "[Ishgard] The Forgotten Knight" | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Sequence": 1, | ||
| "Steps": [ | ||
| { | ||
| "DataId": 1013254, | ||
| "Position": { | ||
| "X": 523.6133, | ||
| "Y": -51.424004, | ||
| "Z": 62.546753 | ||
| }, | ||
| "TerritoryId": 398, | ||
| "InteractionType": "Interact", | ||
| "AetheryteShortcut": "The Dravanian Forelands - Tailfeather" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Sequence": 2, | ||
| "Steps": [ | ||
| { | ||
| "DataId": 1013256, | ||
| "Position": { | ||
| "X": 560.57056, | ||
| "Y": -21.322742, | ||
| "Z": -557.1527 | ||
| }, | ||
| "TerritoryId": 398, | ||
| "InteractionType": "Interact", | ||
| "Fly": true | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Sequence": 3, | ||
| "Steps": [ | ||
| { | ||
| "Comment": "Walk to fishing spot (it's nearby)", | ||
| "Position": { | ||
| "X": 565.8959, | ||
| "Y": -26.253891, | ||
| "Z": -571.15576 | ||
| }, | ||
| "TerritoryId": 398, | ||
| "InteractionType": "WalkTo", | ||
| "SkipConditions": { | ||
| "AetheryteShortcutIf": {"InTerritory": [398]} | ||
| } | ||
| }, | ||
| { | ||
| "Comment": "Fish for 3x Shadowhisker (Bait: Versatile Lure or Blueclaw Shrimp mooch)", | ||
| "TerritoryId": 398, | ||
| "InteractionType": "Fish", | ||
| "ItemsToGather": [ | ||
| { | ||
| "ItemId": 12769, | ||
| "ItemCount": 3 | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Comment": "Turn in fish", | ||
| "DataId": 1013254, | ||
| "Position": { | ||
| "X": 523.6133, | ||
| "Y": -51.424004, | ||
| "Z": 62.546753 | ||
| }, | ||
| "TerritoryId": 398, | ||
| "InteractionType": "Interact" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Sequence": 255, | ||
| "Steps": [ | ||
| { | ||
| "DataId": 1013250, | ||
| "Position": { | ||
| "X": 100.35852, | ||
| "Y": 15.00001, | ||
| "Z": 24.307495 | ||
| }, | ||
| "TerritoryId": 418, | ||
| "InteractionType": "CompleteQuest", | ||
| "AetheryteShortcut": "Ishgard", | ||
| "AethernetShortcut": [ | ||
| "[Ishgard] Aetheryte Plaza", | ||
| "[Ishgard] The Forgotten Knight" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
149 changes: 149 additions & 0 deletions
149
...Paths/3.x - Heavensward/Class Quests/FSH/2088_One Man's Fish Is Another Man's Poison.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| { | ||
| "$schema": "https://qstxiv.github.io/schema/quest-v1.json", | ||
| "Author": "ShermTank", | ||
| "QuestSequence": [ | ||
| { | ||
| "Sequence": 0, | ||
| "Steps": [ | ||
| { | ||
| "DataId": 1013250, | ||
| "Position": { | ||
| "X": 100.35852, | ||
| "Y": 15.00001, | ||
| "Z": 24.307495 | ||
| }, | ||
| "TerritoryId": 418, | ||
| "InteractionType": "AcceptQuest", | ||
| "AetheryteShortcut": "Ishgard", | ||
| "AethernetShortcut": [ | ||
| "[Ishgard] Aetheryte Plaza", | ||
| "[Ishgard] The Forgotten Knight" | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Sequence": 1, | ||
| "Steps": [ | ||
| { | ||
| "DataId": 1000857, | ||
| "Position": { | ||
| "X": -165.27051, | ||
| "Y": 5.2500057, | ||
| "Z": 164.29382 | ||
| }, | ||
| "TerritoryId": 129, | ||
| "InteractionType": "Interact", | ||
| "AetheryteShortcut": "Limsa Lominsa", | ||
| "AethernetShortcut": [ | ||
| "[Limsa Lominsa] Aetheryte Plaza", | ||
| "[Limsa Lominsa] Fishermen's Guild" | ||
| ], | ||
| "SkipConditions": { | ||
| "AetheryteShortcutIf": { "InTerritory": [129]} | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Sequence": 2, | ||
| "Steps": [ | ||
| { | ||
| "Position": { | ||
| "X": 287.34552, | ||
| "Y": -46.72733, | ||
| "Z": 663.33136 | ||
| }, | ||
| "TerritoryId": 400, | ||
| "InteractionType": "WalkTo", | ||
| "Mount": true, | ||
| "AetheryteShortcut": "The Churning Mists - Moghome" | ||
| }, | ||
| { | ||
| "DataId": 1012079, | ||
| "Position": { | ||
| "X": 406.75964, | ||
| "Y": -73.595436, | ||
| "Z": 702.57104 | ||
| }, | ||
| "TerritoryId": 400, | ||
| "InteractionType": "Interact", | ||
| "Fly": true | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Sequence": 3, | ||
| "Steps": [ | ||
| { | ||
| "DataId": 1013824, | ||
| "Position": { | ||
| "X": 441.30603, | ||
| "Y": -29.3383, | ||
| "Z": 218.12769 | ||
| }, | ||
| "TerritoryId": 400, | ||
| "InteractionType": "Interact", | ||
| "Fly": true | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Sequence": 4, | ||
| "Steps": [ | ||
| { | ||
| "Comment": "Walk to fishing spot (it's nearby)", | ||
| "Position": { | ||
| "X": 445.3245, | ||
| "Y": -31.7062, | ||
| "Z": 222.61751 | ||
| }, | ||
| "TerritoryId": 400, | ||
| "InteractionType": "WalkTo" | ||
| }, | ||
| { | ||
| "Comment": "Fish for 1x Letter Puffer (Bait: Giant Crane Fly)", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would usually include a step to have the player buy the bait before fishing, otherwise it will just start casting with whatever they previously had on and it could easily use up all their bait if it's not compatible with the spot or fish. |
||
| "TerritoryId": 400, | ||
| "InteractionType": "Fish", | ||
| "ItemsToGather": [ | ||
| { | ||
| "ItemId": 12793, | ||
| "ItemCount": 1 | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Comment": "Turn in fish", | ||
| "DataId": 1013824, | ||
| "Position": { | ||
| "X": 441.30603, | ||
| "Y": -29.3383, | ||
| "Z": 218.12769 | ||
| }, | ||
| "TerritoryId": 400, | ||
| "InteractionType": "Interact" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Sequence": 255, | ||
| "Steps": [ | ||
| { | ||
| "DataId": 1013250, | ||
| "Position": { | ||
| "X": 100.35852, | ||
| "Y": 15.00001, | ||
| "Z": 24.307495 | ||
| }, | ||
| "TerritoryId": 418, | ||
| "InteractionType": "CompleteQuest", | ||
| "AetheryteShortcut": "Ishgard", | ||
| "AethernetShortcut": [ | ||
| "[Ishgard] Aetheryte Plaza", | ||
| "[Ishgard] The Forgotten Knight" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do not add a fishing present to FishingData.cs, you should instead add a FishingOptions object to the ItemsToGather object. In there, you can set the bait id and hook type. I assume we want to set it to the Versatile Lure. The previous Icepick quest should have an example, though it uses a different bait.