minor improvements #645
Merged
minor improvements #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you for the work and for taking the time to go through it. I've approved a build and I'll review it again later when I'm more awake and hopefully get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've read most of the code repo in order to have a better overview of the features provided by Indigo (and trying to not reinvent the wheel).
While reading the code I thought that I may have an active behavior and suggest some minor improvements.
Most of them are really minor things like adding the explicit type to a variable or function (suggested by the IDE).
There are also a few (minor) changes trying to improve performance when I think it could be done.
Please let me know if you have questions or need some changes to be done to this PR.
Regards,