Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

Stabilize Batch#hashCode#831

Merged
davesmith00000 merged 3 commits intoPurpleKingdomGames:mainfrom
exoego:batch-hashcode
Feb 2, 2025
Merged

Stabilize Batch#hashCode#831
davesmith00000 merged 3 commits intoPurpleKingdomGames:mainfrom
exoego:batch-hashcode

Conversation

@exoego
Copy link
Copy Markdown
Contributor

@exoego exoego commented Feb 2, 2025

Closes #740

Batch#hashCode is now stable regardless of concrete classes (Wrapped or Combine), since now calculated from elements.
Calculation time is increasing proportionally to number of elements.

@exoego exoego marked this pull request as ready for review February 2, 2025 02:26
@exoego exoego changed the title Make Batch#hashCode stable Stabilize Batch#hashCode Feb 2, 2025
Copy link
Copy Markdown
Member

@davesmith00000 davesmith00000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thanks! 🙏

@davesmith00000 davesmith00000 merged commit bd2fde7 into PurpleKingdomGames:main Feb 2, 2025
@exoego exoego deleted the batch-hashcode branch February 2, 2025 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does Batch produce a stable hashCode?

2 participants