Fail build fast in windows#835
Conversation
davesmith00000
left a comment
davesmith00000
left a comment
There was a problem hiding this comment.
Looks good (my powershell knowledge is approaching zero, but it looks plausible!), just one small amend if you could.
| mill indigo-plugin[2.12].checkFormat | ||
| mill indigo-plugin[2.13].checkFormat | ||
| mill indigo-plugin[2.12].publishLocal | ||
| mill indigo-plugin[2.13].publishLocal No newline at end of file |
There was a problem hiding this comment.
I nearly left a different comment here, because mill is a confusing choice of function name. Can you go for something like runMill (or something... get creative). I probably won't look at this script again for months and I don't want to make the same mistake twice. 😄
There was a problem hiding this comment.
I've tidied up the function too, and called it "RunMill". I've also moved the "-i" back into the calls because although I was aiming for a nice proxy function, so my brain did not have to deal with the boilerplate. Slurping up the parameter also made me do a double take on second reading. Hopefully this does the trick.
2 participants
On windows the build does not abort, and merrily runs to completion.
This changes the main build script to fail fast, the indigo-plugin and mill-indigo build scripts too. These were giving false negatives.
Some boilerplate code put into local functions.
The "meat" of the powershell and bash scripts now look much more alike.
This is a practical dependency for #833