This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
FCM support #22
Open
FCM support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stReceiver, refactoring
|
Looks like this also breaks CircleCI for good... |
|
The CI builds have been iffy at best sadly. I'll have a gander at it on a clean machine some time this week probably. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset adds FCM support #21. I have tested it with a self-hosted server and I have encountered no issues with Firebase support. I was able to get push notifications relayed to my phone instantly.
In order to apply this and build the application you will need to generate the
app/google-services.jsonfile from the Firebase ConsoleTwo things to note: this does not appear to work with the "official" Pushjet server, however I wasn't able to debug it properly since there appear to be no client side errors; we can work it out together if you like.
Second, I removed the Google Play Services check; it shouldn't be too hard to restore.