Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage wsfev1 #76

Merged
merged 5 commits into from
Aug 15, 2021
Merged

Coverage wsfev1 #76

merged 5 commits into from
Aug 15, 2021

Conversation

chazuttu
Copy link
Collaborator

Summary

This PR adds unit tests for the script wsfev1.py and increases its code coverage.

  • added unit tests for wsfev1.py
  • updated cassettes
  • increased code coverage to 88% for wsfev1.py

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)
  • Test coverage with pytest implemented
  • Reviewers assigned (at least 1 mentor)

Manual test evidence

Python 3

pytest --cov-config=.coveragerc --cov=pyafipws tests/test_wsfev1.py

============================ test session starts ===========================
platform win32 -- Python 3.9.6, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\Desktop\Week_7_GSOC\pyafipws, configfile: pytest.ini
plugins: cov-2.12.1, freezegun-0.4.2, html-3.1.1, metadata-1.11.0, vcr-1.0.2
collected 26 items

tests\test_wsfev1.py ..........................                                                                                                                                                    [100%]

----------- coverage: platform win32, python 3.9.6-final-0 -----------
Name                                                                                       Stmts   Miss  Cover
--------------------------------------------------------------------------------------------------------------
test3\Lib\site-packages\PyAfipWs-3.9.b_2511_-py3.9.egg\pyafipws\__init__.py                    4      0   100%
test3\Lib\site-packages\PyAfipWs-3.9.b_2511_-py3.9.egg\pyafipws\wsfev1.py                    684     83    88%
--------------------------------------------------------------------------------------------------------------


======================== 26 passed, 2 warnings in 3.67s =========================

Python 2

pytest --cov-config=.coveragerc --cov=pyafipws tests/test_wsfev1.py

============================= test session starts =============================
platform win32 -- Python 2.7.18, pytest-4.6.11, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\Desktop\Week_7_GSOC\pyafipws, inifile: pytest.ini
plugins: cov-2.12.1, freezegun-0.4.2, html-1.22.1, metadata-1.11.0, vcr-1.0.2
collected 26 items

tests\test_wsfev1.py ..........................                          [100%]

---------- coverage: platform win32, python 2.7.18-final-0 -----------
Name                                                                                    Stmts   Miss  Cover
-----------------------------------------------------------------------------------------------------------
test2\Lib\site-packages\PyAfipWs-2.7.2511-py2.7.egg\pyafipws\__init__.py                    4      0   100%
test2\Lib\site-packages\PyAfipWs-2.7.2511-py2.7.egg\pyafipws\wsfev1.py                    674     83    88%
-----------------------------------------------------------------------------------------------------------


========================== 26 passed in 5.47 seconds ==========================

@chazuttu chazuttu requested a review from reingart July 26, 2021 18:35
wsfev1.py Show resolved Hide resolved
@reingart reingart merged commit 02d7bd7 into PyAr:main Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants