Update calls.py with additional rulesets #637
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common vulnerabilities that I have spotted over the years due to the presence of vulnerable python libraries.
ericwb
requested changes
Feb 8, 2022
| @@ -569,4 +569,65 @@ def gen_blacklist(): | |||
| 'attacks. Consider using tmpfile() instead.' | |||
| )) | |||
|
|
|||
| # updated rulesets starts here | |||
|
|
|||
| sets.append(utils.build_conf_dict( | |||
There was a problem hiding this comment.
We already have a bandit plugin to check for use of yaml.load. See https://github.com/PyCQA/bandit/blob/master/bandit/plugins/yaml_load.py
| )) | ||
|
|
||
| sets.append(utils.build_conf_dict( | ||
| 'Base64_encoding_used', 'B328', |
There was a problem hiding this comment.
There are some very good use cases to use base64. In fact, some protocols require it. So there's a very low confidence this check would find a security issue. I'd rather not introduce many more false positives.
| )) | ||
|
|
||
| sets.append(utils.build_conf_dict( | ||
| 'response_splitting', 'B327', |
There was a problem hiding this comment.
This CVE was resolved already in Python 3.7, 3.8, and greater. At this point, I think it's unnecessary for Bandit to flag that module.
|
|
||
| sets.append(utils.build_conf_dict( | ||
| 'Server_Side_Template_Injection', 'B329', | ||
| ['render_template_string', 'render_template'], |
There was a problem hiding this comment.
Are these part of Flask? If so, they would need to be fully qualified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new rule sets to detect common vulnerabilities in default libraries in python.
Some common vulnerabilities observed are -