Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

🐛 Ignore collection failures in non-tests #1

Closed
wants to merge 36 commits into from

Commits on Feb 24, 2023

  1. CI: Modernize, MOAR Pythons, GH-Actions

    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    189fe40 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. MOAR Improvements: Cross-OS testing, .gitignore updates, supporting…

    … only `pylint<3`, coverage at Codecov, drop other CI
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    c5af2e5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from pylint-dev/ci/improve/use-gh-actions

    CI: Use GH-Actions, drop the rest, MOAR Pythons, MOAR OSes, coverage at Codecov
    
    Additionally:
    * Update `.gitignore`
    * Mark the plugin supporting only `pylint<3`
    stdedos committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    6be0547 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    56fa1d1 View commit details
    Browse the repository at this point in the history
  4. Add .pre-commit-config.yaml

    Store all tools' configurations in `pyproject.toml`,
    even if right now only the `setup.py` file is used.
    
    Keep `.pylintrc` separately.
    It is 300 lines; default `--generate-toml-config` gives 600 😅
    
    Comment-out hooks that need >0 work to be green.
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    005174f View commit details
    Browse the repository at this point in the history
  5. pre-commit run -a

    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    85d7e42 View commit details
    Browse the repository at this point in the history
  6. Enable https://github.com/asottile/pyupgrade + .git-blame-ignore-revs

    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    ff18b58 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ab07d5e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5ee69ce View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ae436ac View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a1fc41e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Configuration menu
    Copy the full SHA
    1c2613b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    ae3d8ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec51408 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a4331d View commit details
    Browse the repository at this point in the history
  4. Minor re-ordering of the tool.pylint, with some comments

    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos authored and Pierre-Sassoulas committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    7feeb56 View commit details
    Browse the repository at this point in the history
  5. Carry over some .pylintrc configuration

    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos authored and Pierre-Sassoulas committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a444a61 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    122c799 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    33d1313 View commit details
    Browse the repository at this point in the history
  8. Fix mypy issues

    Most of the issues are "almost clear-cut", except the
    astroid stuff - `pylint_pytest/checkers/class_attr_loader.py`.
    
    Those were mostly placated (but hopefully done right).
    
    Additionally, add some sanity features to `BasePytestTester`:
    * Marked class as `ABC`
    * Enforce subclasses to initialize `MSG_ID`
    
    Mostly both of those changes are "aesthetical",
    and do not contribute to strict guarantees of behavior, or type assertions.
    
    But at least `pytest` cries loudly when used wrong - so that's something.
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b65e979 View commit details
    Browse the repository at this point in the history
  9. Roll back from __future__ import annotations for Python 3.6

    ... and `f{msg_id=}`
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b8ce4ad View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge pull request #9 from pylint-dev/pre-commit-mypy

    Activate mypy in pre-commit
    Pierre-Sassoulas committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2d6d83a View commit details
    Browse the repository at this point in the history
  2. Fix the repository badges

    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    163ac3a View commit details
    Browse the repository at this point in the history
  3. Improvements for .github/workflows/run-tests.yaml

    * Configure action `concurrency:`
    * Use `codecov/codecov-action@v3` flags (might ... help codecov, somehow)
    * Upload testing artifacts
    * Add the Codecov badge in the README.md
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    0b1bb86 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    55e4218 View commit details
    Browse the repository at this point in the history
  5. Fix testing + coverage

    * Drop `py312` to combat #16
    * Install `--editable`, so that Python uses the correct source files for coverage
    * Ignore `tests/input/**/*.py` from coverage - they are not ran properly
    * Again improve on artifact naming
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    c208abb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f8da197 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Release v1.1.3rc0 (#17)

    Additionally, fixes #13
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4971561 View commit details
    Browse the repository at this point in the history
  2. Improve packaging + Release v1.1.3rc1

    * Drop `tests/*` both from `sdist` and `wheel`
    * Drop `universal` wheel (we don't support Python2)
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    85dd457 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #19 from stdedos/release/v1.1.3rc1

    See more details in #19
    stdedos committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    cb653a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. test direct import

    anis-campos committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    630172b View commit details
    Browse the repository at this point in the history
  2. Fixing _is_pytest_fixture

    currently, both fixture in this example are flagged has not fixtures
    ```python
    from pytest import fixture
    
    @fixture
    def my_fixture(): pass
    
    @fixture(name="foo")
    def my_fixture_2(): pass
    ```
    This is due to the different semantics in astroid when using `import pytest` or `from pytest import ...`
    anis-campos committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    d5cd873 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Release v1.1.3

    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    0a47a49 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from anis-campos/fix_is_pytest_fixture

    See more details in #2
    stdedos committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a5c6855 View commit details
    Browse the repository at this point in the history
  3. 🐛 Ignore collection failures in non-tests

    This change applies the pre-existing patterns to identify if the files with collection problems are tests. It is then used to eliminate the false-positives of F6401 (cannot-enumerate-pytest-fixtures).
    
    As a side effect, this patch also includes precise file paths that may be used to reproduce the problem.
    
    Fixes reverbc#20
    Fixes reverbc#21
    
    Signed-off-by: Sviatoslav Sydorenko <[email protected]>
    
    _Replayed; Source PR: https://github.com/reverbc/pylint-pytest/pull/22_
    
    Additionally, satisfied the https://github.com/pylint-dev/pylint-pytest's `.pre-commit-config.yaml`
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    f6a343d View commit details
    Browse the repository at this point in the history
  4. Improve F6401:cannot-enumerate-pytest-fixtures:

    * Capture and return `stdout` and `stderr` (instead of trashing them)
    * Fix the 'duplicate-path' error by `relative`-izing the paths before `union`ing them
    * Update tests to test for both conditions
    
    Additionally, fix two `used-before-assignment` pylint issues (`stdout`, `stderr`) 🤪
    
    Signed-off-by: Stavros Ntentos <[email protected]>
    stdedos committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    abc9f22 View commit details
    Browse the repository at this point in the history