return precipitation bias adjustment factors to run_simulation remove 0.5<x<2 threshold#119
Merged
return precipitation bias adjustment factors to run_simulation remove 0.5<x<2 threshold#119
Conversation
…or greater than 2x
699bd07 to
23a0a9d
Compare
Collaborator
Author
|
Reverted to assessing the gcm precip bias adjustment fraction as the factor of the bias corrected GCM precipitation to the reference period precipitation over the same time period. This check shows that the precipitation after bias adjustment should not differ greatly form the reference climate data. E.g. line 417: Now in the case that the factor is not between 0.5 and 2, a warning will be raised in @drounce would you mind giving this a review? |
drounce
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #118, such that glaciers with a precip bias adjustment factor greater than 2 no longer fail to run due to an assertion.