Skip to content

return precipitation bias adjustment factors to run_simulation remove 0.5<x<2 threshold#119

Merged
btobers merged 4 commits intodevfrom
118_bias_adjust
Aug 18, 2025
Merged

return precipitation bias adjustment factors to run_simulation remove 0.5<x<2 threshold#119
btobers merged 4 commits intodevfrom
118_bias_adjust

Conversation

@btobers
Copy link
Collaborator

@btobers btobers commented Aug 14, 2025

Addresses #118, such that glaciers with a precip bias adjustment factor greater than 2 no longer fail to run due to an assertion.

@btobers btobers self-assigned this Aug 14, 2025
@btobers
Copy link
Collaborator Author

btobers commented Aug 18, 2025

Reverted to assessing the gcm precip bias adjustment fraction as the factor of the bias corrected GCM precipitation to the reference period precipitation over the same time period. This check shows that the precipitation after bias adjustment should not differ greatly form the reference climate data.

E.g. line 417:

    gcm_prec_biasadj_frac = gcm_prec_biasadj_subset.sum(axis=1) / ref_prec.sum(axis=1)

Now in the case that the factor is not between 0.5 and 2, a warning will be raised in run_simulation.py, line 651, but the simulation will keep running.

@drounce would you mind giving this a review?

@btobers btobers requested a review from drounce August 18, 2025 16:53
@btobers btobers marked this pull request as ready for review August 18, 2025 16:54
@btobers btobers merged commit 4be2186 into dev Aug 18, 2025
1 check passed
@btobers btobers deleted the 118_bias_adjust branch August 18, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants