Conversation
…ts and frontal ablation
|
Note, this will fail our test notebooks until a patch to https://github.com/PyGEM-Community/PyGEM-notebooks/tree/dev is completed. Will work on this after #137 is closed. |
|
Note, this is currently failing test_04 - postprocessing, specifically because the |
…er monthly/daily step
|
@drounce I've updated two previous postprocessing scripts following the updates to the mass balance model now running on daily/monthly steps:
Both of these postprocessing scripts will now work with either monthly/daily model outputs. Similarly, the postprocessing teststuite (test_04_postproc.py) has been updated to now call these updates scripts after running through the test notebooks from PyGEM-notebooks. All output variables names have also been updated to remove "monthly." Annual variables still have "annual" in their variable names (e.g. One other major update rolled into this PR: try/except blocks were removed from run_simulation.py. Now, if a particular |
|
@drounce I believe lines 435-438 of glacierdynamics.py should be updated following the new 'days_in_step' datesmodelrun() setup. This is the only place where I found 'daysinmonth' being called, so I believe that the function pygem_modelsetup.daysinmonth() can be removed. |
This has now been address in PR #147, and now I believe we can remove pygem_modelsetup.daysinmonth() |
pygem_modelsetup.daysinmonth() function removed in PR #147 |
…y for tidewater glaciers that still needs to be checked
Adding the functionality throughout the mass balance functions, dates table, cfg files, etc. to include mass balance functionality