Reformat MCMC calibration framework to make more modular#155
Merged
Conversation
…ating log likelihood of each step
Collaborator
Author
|
@drounce this PR is ready for review. Itslightly reformats the mcmc framework to make it far more modular. The observations and predictions are now stored as dictionaries with matching keys, so no variables are hard-coded in the computation of log-likelihoods. This PR also modifies the chain plotting to now include the along-chain average residual for calibration other than the glacier wide balance (e.g. binned elevation change, snowline elevation, etc.). |
drounce
approved these changes
Nov 4, 2025
btobers
added a commit
that referenced
this pull request
Nov 4, 2025
Closes #152 * Allow user to specify their own mass balance dataset and field names Closes #156 * process 2d dhdt to glacierwide mass balance and 1d elev change profiles * Add dhdt_processing notebook to test suite * Reformat MCMC calibration framework to make more modular (#155) Closes #151 * set up obs and preds of mcmc as dictionary and match keys when calculating log likelihood of each step Closes #154 * Plot residual for any pred-obs pairs that aren't glacierwide mb, whether 2d or 1d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up observation and prediction variables as dictionary with matched keys to compare in log-likelihood estimation. This removes the hard-coded dependence that the observed and predicted mass balance are the 0th elements, and the observed and predicted elevation change (if available) are the 1st elements. This will make for a more robust calibration framework as various datasets are incorporated.