Skip to content

Run tests as part of CI#59

Merged
ddundo merged 28 commits intodevfrom
53_ci_test
Feb 27, 2025
Merged

Run tests as part of CI#59
ddundo merged 28 commits intodevfrom
53_ci_test

Conversation

@ddundo
Copy link
Contributor

@ddundo ddundo commented Feb 14, 2025

Closes #53.

This PR adds a workflow that runs the test suite every Saturday and every time commits are pushed to open PRs or to the master and dev branches. In the interest of green computing, it is only triggered if these commits change at least one of these files:

  • any .py file
  • the workflow itself, i.e., .github/workflows/test_suite.yml
  • pyproject.toml so that we can test the installation

@ddundo ddundo changed the base branch from master to 52_docker February 14, 2025 20:16
@ddundo ddundo self-assigned this Feb 14, 2025
@ddundo ddundo added the testing label Feb 14, 2025
@ddundo ddundo marked this pull request as ready for review February 14, 2025 20:50
@ddundo
Copy link
Contributor Author

ddundo commented Feb 14, 2025

This is ready to review. Tests fail as described in #50, i.e., unrelated to changes here.

I will uncomment the linting job when #57 gets merged.

Edit: I ended up deleting test_oggm_compat.py to not have failing tests and since it needs to be completely rewritten anyway :)

@ddundo ddundo marked this pull request as draft February 14, 2025 21:50
@ddundo ddundo marked this pull request as ready for review February 14, 2025 21:58
@ddundo ddundo force-pushed the 52_docker branch 2 times, most recently from 79d9a91 to 4374283 Compare February 26, 2025 21:11
@ddundo ddundo marked this pull request as draft February 26, 2025 21:29
Base automatically changed from 52_docker to dev February 27, 2025 15:43
@ddundo ddundo marked this pull request as ready for review February 27, 2025 20:47
@ddundo ddundo requested a review from btobers February 27, 2025 20:47
@ddundo
Copy link
Contributor Author

ddundo commented Feb 27, 2025

@btobers this is ready for review when you have time :) please also tell me if something is unclear and requires more comments

Copy link
Collaborator

@btobers btobers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks again for implementing the tests!

@ddundo ddundo merged commit 952d6cc into dev Feb 27, 2025
1 check passed
@ddundo ddundo deleted the 53_ci_test branch February 27, 2025 21:13
btobers pushed a commit that referenced this pull request Mar 13, 2025
Closes #53.

This PR adds a workflow that runs the test suite every Saturday and every time commits are pushed to open PRs or to the master and dev branches. In the interest of green computing, it is only triggered if these commits change at least one of these files:
- any `.py` file
- the workflow itself, i.e., `.github/workflows/test_suite.yml`
- `pyproject.toml` so that we can test the installation

Deleted `test_oggm_compat.py` since all tests fail anyway.
btobers pushed a commit to btobers/PyGEM that referenced this pull request Mar 16, 2025
Closes PyGEM-Community#53.

This PR adds a workflow that runs the test suite every Saturday and every time commits are pushed to open PRs or to the master and dev branches. In the interest of green computing, it is only triggered if these commits change at least one of these files:
- any `.py` file
- the workflow itself, i.e., `.github/workflows/test_suite.yml`
- `pyproject.toml` so that we can test the installation

Deleted `test_oggm_compat.py` since all tests fail anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a CI workflow to run tests

2 participants