Skip to content

Contribution guide#84

Merged
btobers merged 8 commits intodevfrom
51_dev_guide
Mar 12, 2025
Merged

Contribution guide#84
btobers merged 8 commits intodevfrom
51_dev_guide

Conversation

@btobers
Copy link
Collaborator

@btobers btobers commented Mar 12, 2025

Closes #51.

Contribution guide added to PyGEM documentation. Installation instructions also expanded upon.

@btobers btobers requested a review from ddundo March 12, 2025 18:08
@btobers
Copy link
Collaborator Author

btobers commented Mar 12, 2025

@ddundo would you be able to provide a quick review on this? This PR only involves updates to the documentation, mainly just adding the contribution guide you drafted. Thanks for doing so!

@btobers btobers self-assigned this Mar 12, 2025
@btobers btobers marked this pull request as ready for review March 12, 2025 18:10
Copy link
Contributor

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few suggestions, but almost all minor - so I will approve so you can merge when you're happy :)

btobers and others added 3 commits March 12, 2025 16:35
Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com>
Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com>
@btobers
Copy link
Collaborator Author

btobers commented Mar 12, 2025

Quite a few suggestions, but almost all minor - so I will approve so you can merge when you're happy :)

Thanks for taking the time to look this over, great suggestions!

@btobers btobers merged commit 947d353 into dev Mar 12, 2025
1 check passed
@btobers btobers deleted the 51_dev_guide branch March 12, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants