Conversation
Closes #52. This PR adds a workflow to automatically build and push the PyGEM image to the GitHub Container Registry (ghcr.io), that will then be visible at https://github.com/orgs/PyGEM-Community/packages. It builds it from the Dockerfile that I add as well. It's pushed to ghcr only when the workflow is triggered on the master or dev branches: that is, if it's triggered by schedule or when we merge relevant commits to the branches. But it's always built in PRs so we can check that it builds successfully. Currently the image is quite large (9.1 GB) but can be reduced to about 2.5GB, as described in #60.
Closes #53. This PR adds a workflow that runs the test suite every Saturday and every time commits are pushed to open PRs or to the master and dev branches. In the interest of green computing, it is only triggered if these commits change at least one of these files: - any `.py` file - the workflow itself, i.e., `.github/workflows/test_suite.yml` - `pyproject.toml` so that we can test the installation Deleted `test_oggm_compat.py` since all tests fail anyway.
Partially addresses #50. With this PR, `simple_test.ipynb` and `advanced_test.ipynb` will now be automatically tested in CI. Other notebooks can be added later.
* config.py now object oriented and contains update_config() function * all prior calls to config updated for compatability with new config.ConfigManager class * raise errors, and ensure that dictionary keys are not overwritten * create_config() function created and _prompt_overwrite() function removed to clean up the class and remove redundancy * config test created * update source_config_path Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com> * remove self.package_dir definition * update source path Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com> * rename ruamel.yaml.YAML() as ryaml * call ensure_config() upon __init__ * user config validation, make sure necessary keys exist * ConfigManager.ensure_config() calls removed, now handled on __init__ * bug fix with commit:4fd5493 * more tests added to test_config * more tests and TypeError checks in update_config * test ensure config, no overwrite * remove CLI update_config funcitonality * Handle datatypes in `config.yaml` and expand tests (#79) * clean up imports Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com> * add `advanced_test_tw.ipynb` test * typo fix * add __all__ variable Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com> * cleanup commenting Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com> * cleanup commenting Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com> * more descriptive variable in validate_config * private methods and expanded docstrings * swap PyGEM-Notebooks clone repo back to main branch * clone appropriate PyGEM-notebook brach * comment added --------- Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com>
Closes #51. Contribution guided added to documentation. PyGEM installation instructions expanded upon. `pygem_environment.yml` file created for simple install.
drounce
approved these changes
Mar 13, 2025
Contributor
|
If I can push my nose in... I think it would be good to not squash commits when merging from dev to master. That way we retain a more complete commit history on the master branch, so it's easier to track changes/new features/etc. |
Collaborator
Author
I completely agree. I was just looking into why the only option that shows up is "Squash and merge" |
Collaborator
Author
|
Got it, we just had the "Allow merge commits" option disabled in Settings->General. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pygem.setup.config.ConfigManagerclass created, automated tests set up for PRs todevandmasterbranches.