Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force pylablib version to 1.4.1 #17

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Force pylablib version to 1.4.1 #17

merged 1 commit into from
Nov 21, 2023

Conversation

rgeneaux
Copy link
Contributor

Hi,
We've found out that the last pylablib version (1.4.2) throws a bug at initialization of Thorlabs TSI cameras. So I'd like to stay with 1.4.1 for now - is that ok with the color features you added?

@seb5g
Copy link
Contributor

seb5g commented Nov 15, 2023

well the guy from pylablib told be the new release is actually taking care of camera colors and debayering process in case of color camera. So I wanted to move into using it but I could not test it so far, what's the issue you're talking about. Did you raise an issue on pylablib?

@rgeneaux
Copy link
Contributor Author

No I need to write a minimal test outside of pymodaq to verify which functions throws errors (looks like there are several, happening when you initialize the controller).

@rgeneaux
Copy link
Contributor Author

Issue raised on pylablib here: AlexShkarin/pyLabLib#65

@seb5g
Copy link
Contributor

seb5g commented Nov 16, 2023

well the problem is that version 1.4.2 introduces many new instruments and I've been using the Keithley2110. So forcing version 1.4.1 would be an issue for people who want to use these new ones. Can't we patch the TLCameras object within our plugin to get it working while pylablib publishes a correction?

@rgeneaux
Copy link
Contributor Author

I tried to understand the error but I didn't succeed, it's a bit cryptic..

@seb5g
Copy link
Contributor

seb5g commented Nov 20, 2023

did the guy replied?

@rgeneaux
Copy link
Contributor Author

not yet!

@seb5g
Copy link
Contributor

seb5g commented Nov 20, 2023

don't know what to do...

@seb5g seb5g closed this Nov 20, 2023
@seb5g seb5g reopened this Nov 20, 2023
@rgeneaux
Copy link
Contributor Author

I'd say the priority is that whatever is on pypi is stable. Even at the cost of more functionality.
So until the PR is solved on pylablib, I think we force the plugin to pylablib==1.4.1 on the pypi version, and create another branch here that works in 1.4.2, so that users that know a bit more what they're doing can use it

@seb5g
Copy link
Contributor

seb5g commented Nov 21, 2023

ok but you have to let us now when your issue has been replied by pylablib

@seb5g seb5g merged commit de0549a into PyMoDAQ:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants