Filter Cargo.toml.orig from sdist#271
Conversation
This path began appearing in the output of cargo package --list --allow-dirty --manifest-path=Cargo.toml around nightly-2020-02-22. It doesn't exist prior to the call and isn't created by it. This causes: 💥 maturin failed Caused by: Failed to build source distribution Caused by: Failed to add file from Cargo.toml.orig to sdist as Cargo.toml.orig Caused by: No such file or directory (os error 2) when getting metadata for Cargo.toml.orig
|
Imho this is a cargo bug, caused by rust-lang/cargo#7905. I've filed this as a bug in rust-lang/cargo#7938. Thanks for reporting this! |
|
(I'm going to leave this open until there is a decision on the bug report. In case they argue that it is correct to include Cargo.toml.orig, I'm going to merge this) |
|
It's a fatal error to maturin but not a practical issue for cargo, and there are rust releases with this behavior even if it's fixed later, so it may worth just working around anyway. |
|
The instructions int the README no longer work due to this issue, for the release version of maturin. When I added |
|
For some unfortunate reason, Google does not find this issue when I search "Failed to add file from Cargo.toml.orig to sdist as Cargo.toml.orig". It took me quite some time to get here, and I worry others might be similarly stuck. |
|
So it seems we actually need to filter ourselves. Thanks again for the pull request! |
This path began appearing in the output of
cargo package --list --allow-dirty --manifest-path=Cargo.toml around
nightly-2020-02-22. It doesn't exist prior to the call and isn't created
by it. This causes:
💥 maturin failed
Caused by: Failed to build source distribution
Caused by: Failed to add file from Cargo.toml.orig to sdist as Cargo.toml.orig
Caused by: No such file or directory (os error 2) when getting metadata for Cargo.toml.orig