Repository navigation
Add --python-implementation option to generate-ci - #3318
Closed
astravaleheart wants to merge 1 commit into
Closed
astravaleheart wants to merge 1 commit into
astravaleheart wants to merge 1 commit into
Conversation
Closes PyO3#2013. maturin generate-ci github only ever set up CPython via actions/setup-python and built wheels with --find-interpreter, which doesn't discover PyPy or GraalPy executables (they aren't named pythonX.Y). Add --python-implementation <cpython|pypy|graalpy> (default cpython, so existing output is unchanged) that selects the matching actions/setup-python python-version value and passes an explicit -i <interpreter> to maturin build instead of --find-interpreter. When a non-CPython implementation is selected, the free-threaded build step is skipped (free-threading is a CPython-specific ABI concept) and the Windows architecture matrix input is omitted, since PyPy/GraalPy don't publish prebuilt arm64 Windows interpreters; users who need to change targets per-implementation can still do so via the existing [tool.maturin.generate-ci.github.<platform>] targets override in pyproject.toml.
Author
|
Apologies — this PR was opened by an automated system under test that acted outside its intended approval gate. Withdrawing it; sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2013.
What
Adds a
--python-implementation <cpython|pypy|graalpy>option tomaturin generate-ci, defaulting tocpython(no change to existing output). Whenpypyorgraalpyis selected, the generated GitHub Actions workflow:actions/setup-python(pypy3.<minor>orgraalpy24.2) instead of a CPython version string-i <interpreter>instead of--find-interpreter(which only matchespythonX.Y-style names and won't discover PyPy/GraalPy binaries)architecturematrix input, since PyPy/GraalPy don't ship prebuilt Windows arm64 interpretersWhy
Issue #2013 asks for a CLI option to select the target Python implementation for
generate-ci, since today the generated workflow only knows how to set up and target CPython. This closes that gap for the two implementations PyO3 itself already supports (PyPy via PyO3/pyo3#393, GraalPy via PyO3/pyo3#3247).How tested
cargo test --lib: 273 passed, 0 failed, including 3 new tests covering the PyPy/GraalPy code paths; all pre-existinggenerate-cisnapshot tests pass unmodified, confirming thecpythondefault is unaffectedcargo fmt --all -- --checkandcargo clippy --tests --all-features -- -D warnings: both cleanmaturin generate-ci github --python-implementation pypy -m test-crates/pyo3-pure/Cargo.toml) and reviewed the YAML output across all platform jobsKnown limitation
The default Windows target list still includes
aarch64, which has no PyPy/GraalPy build available. This is user-fixable today via the existing[tool.maturin.generate-ci.github.windows] targets = [...]pyproject.toml override; teachinggenerate-cito auto-filter targets per implementation would be a separate follow-up and is out of scope here.maturin.schema.jsonis intentionally unchanged -- this is a CLI-only flag (like--skip-attestation), not apyproject.tomlconfig key.