Refactor the exception macros #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed `py_exception` to `create_exception` * The split up of the macros makes it possible to create exception structs with bodies to mimic python exceptions' members * Used `Once` to fix a (theoretical) race condition with the is_null check
|
I think this PR itself is good. |
|
The plan is to have a custom derive, which was originally suggested by mre in mre/hyperjson#54. This PR is the base work for a custom derive by splitting out the reusable parts. |
|
Turns out we should use a full proc macro instead a custom derive, but that shouldn't really matter. I've written #295 with detailed mentoring instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py_exceptiontocreate_exceptionOnceto fix a (theoretical) race condition with the is_null check