Documents experimental-declarative-modules feature #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
force-pushed
the
tpt/declarative-guide
branch
2 times, most recently
from
77cbca7 to
858793c
Compare
davidhewitt
reviewed
Mar 12, 2024
|
|
||
| An other syntax based on Rust inline modules is also available to declare modules. | ||
| The `experimental-declarative-modules` feature must be enabled to use it. | ||
|
|
There was a problem hiding this comment.
Should we briefly note what might be subject to change before we call this ready? I guess mostly it is the submodule automatically going to sys.modules and also the setting of #[pyclass(module = ....)].
We could also add a link to the issue.
(And I guess we thought we might change the attribute names, though I'm feeling quite happy about those.)
There was a problem hiding this comment.
Done: 6b31c39
BTW, sorry for my English, as you can see it's not my native language
Tpt
force-pushed
the
tpt/declarative-guide
branch
from
858793c to
6b31c39
Compare
davidhewitt
approved these changes
Mar 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.