Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid reference count cycle in tuple extraction #3976

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

davidhewitt
Copy link
Member

Just noticed a very minor inefficiency introduced to FromPyObject for Rust tuples which inadvertently got introduced by the change to the Bound API (and the choice to move borrowed methods to new names).

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Mar 21, 2024
Copy link

codspeed-hq bot commented Mar 21, 2024

CodSpeed Performance Report

Merging #3976 will not alter performance

Comparing davidhewitt:tuple-extract (990e3e3) with main (d0f5b6a)

🎉 Hooray! codspeed-rust just leveled up to 2.4.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 67 untouched benchmarks

@davidhewitt
Copy link
Member Author

Will proceed to merge as this is a tiny fixup and it'd be nice to include it in the 0.21 release.

@davidhewitt davidhewitt enabled auto-merge March 22, 2024 21:41
@davidhewitt davidhewitt added this pull request to the merge queue Mar 22, 2024
Merged via the queue into PyO3:main with commit 20e477a Mar 22, 2024
39 of 40 checks passed
@davidhewitt davidhewitt deleted the tuple-extract branch March 22, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant