feat: support pyclass on tuple enums (closer but not there yet)#4135
Closed
feat: support pyclass on tuple enums (closer but not there yet)#4135
Conversation
Member
|
Thanks for continuing the work here! These double underscore methods are a bit special in how their code generation works. // `slot` is `__GETITEM__`/`__LEN__` from `pyo3-macros-backend/src/pymethods`
slot.generate_type_slot(variant_cls_type, &spec, &name, ctx)to generate these special definitions and thread them back up into fn __getitem__(slf: PyRef<Self>, idx: usize) -> PyResult<PyObject> {...}
fn __len__(slf: PyRef<Self>) -> usize {...}There should be no need to use Just for future reference: We might also want to generate |
6 tasks
Contributor
Author
|
Closing in favour of #4072 which has picked this up again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extension of this PR, which hasn't been updated in two weeks:
#4072
Aiming to close this issue:
#3748
@newcomertv in that PR added support for tuple enums but only with
._0._1access to elements.This PR attempts to do the following:
[0][1]access on tuple elements with__getitem__()I've got the Rust-side macros working but haven't yet managed to get them wired up on the Python side... Main complication is that the
__getitem__()implementation has to return aBox<dyn Any>(as the type won't be known) and I haven't figured out how to deal with that on the other side.Will give it another go soon but putting this up in case anyone has suggestions...