Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix struct layouts on GraalPy #4802

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

msimacek
Copy link

  • The initial GraalPy support PR removed some struct fields with the intention of hiding them. But the fields are physically present, which caused layout mismatch when users tried to subclass them via PyO3. I add them back.
  • I also exposed a few functions, which were previsously omitted on GraalPy, but are actually available.

CC @timfel

@davidhewitt
Copy link
Member

Thanks for the PR! Should we be bumping our supported graalpy version, both by what we check for and what we test against in CI?

@msimacek
Copy link
Author

Hi, there is no need to bump the checked version, I didn't introduce any dependency on anything from newer versions. I can update the version in the CI, but I'd prefer to do that in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants