Fix generating import lib for python3.13t when abi3 feature is enabled #4808
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
force-pushed
the
fix-generate-import-lib-for-python3.13t-with-abi3
branch
2 times, most recently
from
f8be1d7 to
fd14e98
Compare
messense
commented
Dec 19, 2024
| @@ -1530,16 +1535,26 @@ fn default_cross_compile(cross_compile_config: &CrossCompileConfig) -> Result<In | |||
| let implementation = cross_compile_config | |||
| .implementation | |||
| .unwrap_or(PythonImplementation::CPython); | |||
| let gil_disabled = false; | |||
There was a problem hiding this comment.
so we are still missing python3.13t support for PYO3_CROSS_PYTHON_VERSION, but I'm running out of energy to implement it today.
messense
force-pushed
the
fix-generate-import-lib-for-python3.13t-with-abi3
branch
from
fd14e98 to
8cb4848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with #4800 and PyO3/python3-dll-a#84, resolves PyO3/maturin#2385 for both native and cross compilation.