Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive(FromPyObject): support raw identifiers #4814

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Dec 23, 2024

Other macros like #[pyclass] already "unraw" identifiers, applying this to derive(FromPyObject) for consistency

@Tpt Tpt force-pushed the derive-from-pyobject-keyword branch from a59f973 to 562168b Compare December 23, 2024 10:01
@Tpt Tpt requested a review from Icxolu December 23, 2024 10:16
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks perfect to me!

@Icxolu Icxolu added this pull request to the merge queue Dec 23, 2024
Merged via the queue into PyO3:main with commit 54cfaf2 Dec 23, 2024
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants