Raise when data is both specification and section #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Wouda
reviewed
Jun 24, 2024
Comment on lines
+241
to
+244
| "SERVICE_TIME: 10", | ||
| "SERVICE_TIME_SECTION", | ||
| "1 20", | ||
| "2 20", |
There was a problem hiding this comment.
What happens when the section comes before the specification? Does that also raise?
There was a problem hiding this comment.
That raises an error, but it's not related to sections coming before specifications. I think we should be strict and add that too. I'll do that in another PR
N-Wouda
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR raises errors when parsing VRPLIB instances that uses the same keyword as specification and data section.