lint: add type hints and test for them #29
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Relies on #27 for a clean lint run. |
miketheman
commented
Nov 20, 2024
| return True | ||
|
|
||
| return attempt + 1 == attempts | ||
| return attempt + 1 == attempts # type: ignore[no-any-return] # TODO: what's the best way to determine these? |
Author
There was a problem hiding this comment.
I'm not certain how to inspect these, since both attempt and attempts could be t.Any, due to the untyped nature of request.environ (a dict) and they are being set earlier on.
I contemplated adding assert isinstance(attempt, int); assert isinstance(attempts, int) but that felt clunky too.
Introduce `mypy` and apply strict type hints. Declare typed support via marker file and classifier. Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
mypyand apply strict type hints.Declare typed support via marker file and classifier.