-
Notifications
You must be signed in to change notification settings - Fork 558
Fix PyROS IntersectionSet Implementation
#3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix PyROS IntersectionSet Implementation
#3786
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3786 +/- ##
==========================================
+ Coverage 89.40% 89.42% +0.01%
==========================================
Files 909 909
Lines 105541 105579 +38
==========================================
+ Hits 94364 94416 +52
+ Misses 11177 11163 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsiirola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. One minor documentation request, but nothing I would hold up the PR for.
| Returns | ||
| ------- | ||
| : list of tuple | ||
| list of tuple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, this would be a formal type:
| list of tuple | |
| list[tuple[float, float]] |
(this comment applies below, too)
Summary/Motivation:
This PR resolves issues introduced in #3341, to ensure that PyROS truly supports
IntersectionSetinstances representing intersections of uncertainty set sequences containing either of the following:CardinalitySet,FactorModelSet)DiscreteScenarioSet)These use cases are now covered in the PyROS automated tests.
Changes proposed in this PR:
IntersectionSetimplementation for cases where discrete sets and/or sets involving auxiliary parameters are to be intersectedUncertaintySetbase class attributesLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: