Improve containerization process #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a deterministic image for Docker - Add documentation about base image on Dockerfile Signed-off-by: Daniel Campos Olivares <[email protected]>
Signed-off-by: Daniel Campos Olivares <[email protected]>
- Include Hadolint on the PR workflow process Signed-off-by: Daniel Campos Olivares <[email protected]>
upkarlidder
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if they modify the target image on the RedHat registry, we will always point to the desired one.
Fail the check job if the Dockerfile doesn't follow the Docker images best practices.
This could be considered a Patch.
It partially addresses: