Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version only up to minor changes #60

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Pin version only up to minor changes #60

merged 1 commit into from
Jan 21, 2022

Conversation

dacamposol
Copy link
Contributor

Apparenty APT, as the Alpine repository, only stores up to the minor changes and it discards the bugfixes and build versions from its cache.

Due to that, we're pinning up until the minor change in the Dockerfile, and we will let latest build and bugfix increments to be downloaded on the container.

Refers to: Pyrrha-Platform/Pyrrha-Deployment-Configurations#13

Signed-off-by: Daniel Campos Olivares <[email protected]>
@dacamposol
Copy link
Contributor Author

@upkarlidder since I don't have access to the org, I cannot add you as reviewer.

Please check.

@upkarlidder
Copy link
Member

Works for me locally and passes the docker build test. Thank you @dacamposol 🎉

@fyi @albertum1

Copy link
Member

@upkarlidder upkarlidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@upkarlidder upkarlidder merged commit bf9854b into Pyrrha-Platform:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants