Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notebook number to list of exercises to check #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RuthMahallaMilano
Copy link

No description provided.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. All of the files appear to be ones we're not sure how to review. We're working on it!

Comment on lines +25 to +27
{%- if exercise['notebook'] %}
<td>{{ exercise['notebook'] }}</td>
{%- endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment:

Suggested change
{%- if exercise['notebook'] %}
<td>{{ exercise['notebook'] }}</td>
{%- endif %}
{%- if exercise['notebook'] %}
<td>{{ exercise['notebook'] }}</td>
{%- endif %}

@@ -10,6 +10,7 @@ <h1>{{ _('Exercises operations room') }}</h1>
<tr>
<th scope="col">#</th>
<th scope="col">{{ _('Name') }}</th>
<th scope="col">{{ _('Notebook') }}</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if any of the exercises has notebook before showing this column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants