Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalize button now disabled if there is no winner #32

Merged
merged 2 commits into from
Feb 16, 2017

Conversation

akita8
Copy link
Contributor

@akita8 akita8 commented Feb 8, 2017

Ho modificato il template di finalize con un if che controlla se la variabile iniettata 'winners' è una lista vuota e aggiunge disabled alla classe del bottone come da docs di bootstrap.

Ho aggiunto un altro commit riguardante la issue #29 per non creare un altra PR per una modifica così piccola.

Copy link
Member

@keobox keobox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Copy link
Member

@keobox keobox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@zanza00
Copy link
Contributor

zanza00 commented Feb 16, 2017

Ottimo lavoro :)

@zanza00 zanza00 merged commit 9ec3d2f into PythonMilano:develop Feb 16, 2017
@akita8 akita8 deleted the fix-issue-30 branch April 19, 2017 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants