Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdk11 -- dropped jdk8 support #201

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
e6762d1
removed all platform-jdk* profiles and replaced all definitions with …
Oct 11, 2023
969ca3e
removed jdk8 builds
Oct 11, 2023
df07724
Merge branch 'main' into 198-drop-jdk8-support-and-migrate-to-jgiven-…
adrian-herscu Oct 11, 2023
9005748
changed to run with jdk 11
adrian-herscu Oct 11, 2023
5860a0c
disabled tests due to jdk 11 incompatibility
adrian-herscu Oct 11, 2023
8864612
disabled tests due to jdk 11 incompatibility -- it tries to run with …
adrian-herscu Oct 11, 2023
25cd2d9
added note regarding lombok-maven-plugin incompatibility with jdk 21
adrian-herscu Oct 11, 2023
ab68896
upgraded maven plugins
adrian-herscu Oct 12, 2023
494b1b1
formatted by new maven formatter plugin
adrian-herscu Oct 12, 2023
74d8a91
upgraded dependencies
adrian-herscu Oct 12, 2023
add8361
upgraded to jersey 3
adrian-herscu Oct 12, 2023
dccd366
minor versions
adrian-herscu Oct 13, 2023
165c6fa
fixed to compile on jdk 21
adrian-herscu Oct 13, 2023
857be0b
higher versions of derbyclient are compiled with jdk17
adrian-herscu Oct 14, 2023
fc101dd
formatting
adrian-herscu Oct 14, 2023
4992a3a
testCompile fails due to JDK 11 modules
adrian-herscu Oct 14, 2023
aa8604c
removed jdk 11 problematic dependencies, java-8-matchers and json-pat…
adrian-herscu Oct 14, 2023
9c199b1
testCompile succeeds; still, surefire fails to launch
adrian-herscu Oct 14, 2023
b2467cf
fixed to work with jgiven 1.3
adrian-herscu Oct 14, 2023
0479a8f
fixed compilation errors
adrian-herscu Oct 14, 2023
2cd832b
JGiven 1.3 changed structure of JSON report files
adrian-herscu Oct 14, 2023
d3400dc
Merge branch 'main' into 198-drop-jdk8-support-and-migrate-to-jgiven-…
adrian-herscu Oct 29, 2023
26e4a61
fixed to prevent logback diagnostic logs
adrian-herscu Oct 30, 2023
fddcd48
fixed to run with selenium 4
adrian-herscu Oct 31, 2023
9e40843
formatting
adrian-herscu Oct 31, 2023
6c3e5d6
upgraded findbugs to spotbugs
adrian-herscu Oct 31, 2023
3dc60d9
upgraded to appium 9
adrian-herscu Oct 31, 2023
e23d4d1
formatting
adrian-herscu Oct 31, 2023
220f50f
added/updated failure descriptions
adrian-herscu Oct 31, 2023
f36cf5b
added jpms error descriptions
adrian-herscu Oct 31, 2023
7beac37
rebuild full without signing
adrian-herscu Oct 31, 2023
419596c
upgraded appium 8 to 9
adrian-herscu Oct 31, 2023
f562d63
updated to use jdk11
adrian-herscu Nov 1, 2023
96b38fa
added test folders
adrian-herscu Nov 1, 2023
4662f39
still fails to compile java 11 in eclipse
adrian-herscu Nov 1, 2023
f5533ed
added eclipse testng launcher note
adrian-herscu Nov 1, 2023
540c9e3
fixed to work with selenium 4; appium 9 needs further testing
adrian-herscu Nov 3, 2023
c580478
fixed to match example
adrian-herscu Nov 3, 2023
1d08f52
fixed to generate automation project with java 11
adrian-herscu Nov 3, 2023
595a2d4
fixed to comply with selenium 4
adrian-herscu Nov 3, 2023
920521b
fixed to run via java_home instead of system path
adrian-herscu Nov 3, 2023
da7fe11
fixed to run the tests
adrian-herscu Nov 4, 2023
abc20b3
https://stackoverflow.com/questions/77423742/surefire-testng-fails-to…
adrian-herscu Nov 4, 2023
5c1184f
preliminary fix of surefire jpms launch failure
adrian-herscu Nov 7, 2023
d78e7da
removed all exclusions
adrian-herscu Nov 7, 2023
1cd2ded
formatted
adrian-herscu Nov 7, 2023
0151ebf
removed irrelevant properties
adrian-herscu Nov 7, 2023
02b456b
removed irrelevant jpms argument
adrian-herscu Nov 7, 2023
dc7dbb6
Merge pull request #203 from QA-Automation-Starter/surefire-testng-fa…
adrian-herscu Nov 7, 2023
edc8bcf
validated -- still parallel data providers don not work
Nov 9, 2023
c8e5324
parallel data providers not supported -- issue opened
adrian-herscu Nov 9, 2023
7486e1a
renamed to match its purpose
adrian-herscu Nov 9, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .github/workflows/on-main-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ jobs:

strategy:
matrix:
java-version: [ 17, 11, 8 ]
# ISSUE on JDK 21 -- see on-pull-request.yml
java-version: [ 21, 17, 11 ]
os: [ ubuntu-latest, macos-latest, windows-latest ]

steps:
Expand All @@ -47,8 +48,8 @@ jobs:
mvnw install ^
-s %GITHUB_WORKSPACE%\settings.xml

deploy-for-jdk8:
name: jdk-8 snapshot publish
deploy-for-jdk11:
name: jdk-11 snapshot publish
# ISSUE ChromeDriver/GeckoDriver fail to initialize on Ubuntu
# see https://github.com/QA-Automation-Starter/qa-automation/actions/runs/3294884059/jobs/5432863668
# see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
Expand All @@ -61,7 +62,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
java-version: '8'
java-version: '11'
distribution: 'temurin'
cache: maven
settings-path: ${{ github.workspace }}
Expand Down Expand Up @@ -97,10 +98,15 @@ jobs:
# same as in on-pull-request.yml
generate-automation-project:
name: Generates new automation project and builds it
needs: deploy-for-jdk8
needs: deploy-for-jdk11
runs-on: ubuntu-latest

steps:
- uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'temurin'

- name: setup maven for sonatype snapshots
uses: whelk-io/maven-settings-xml-action@v20
with:
Expand Down Expand Up @@ -135,11 +141,12 @@ jobs:
- name: generate testing project
# ISSUE https://stackoverflow.com/questions/74581510/using-latest-for-archetypeversion-always-resolves-to-latest-release
# NOTE will use last released archetype
# TODO after 1.0.0 release should change DarchetypeVersion to LATEST
run: |
mvn --batch-mode archetype:generate \
-DarchetypeGroupId=dev.aherscu.qa \
-DarchetypeArtifactId=qa-testing-archetype \
-DarchetypeVersion=LATEST \
-DarchetypeVersion=1.0.0-SNAPSHOT \
-DgroupId=com.acme \
-DartifactId=testing \
-Dversion=1.0-SNAPSHOT \
Expand Down
27 changes: 21 additions & 6 deletions .github/workflows/on-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@ jobs:

strategy:
matrix:
java-version: [ 17, 11, 8 ]
# ISSUE on JDK 21 --
# when running aggregated as
# mvnw install mode-build-full mode-build-nosign testing-tutorials
# while running qa-testing-example:
# Cannot define class using reflection: Unable to make protected java.lang.Package
# when running verify on qa-testing-example standalone:
# java.lang.RuntimeException: ProcessBuilder.start() debug
# (in addition)
# In summary, on JDK 21 the tests do not work.
java-version: [ 21, 17, 11 ]
os: [ ubuntu-latest, macos-latest, windows-latest ]

steps:
Expand All @@ -44,8 +53,8 @@ jobs:
mvnw install ^
-s %GITHUB_WORKSPACE%\settings.xml

verify-for-jdk8:
name: jdk-8 verify
verify-for-jdk11:
name: jdk-11 verify
# ISSUE ChromeDriver/GeckoDriver fail to initialize on Ubuntu
# see https://github.com/QA-Automation-Starter/qa-automation/actions/runs/3294884059/jobs/5432863668
# see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
Expand All @@ -58,7 +67,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
java-version: '8'
java-version: '11'
distribution: 'temurin'
cache: maven
settings-path: ${{ github.workspace }}
Expand Down Expand Up @@ -102,10 +111,15 @@ jobs:

generate-automation-project:
name: generate-build-run-standalone
needs: verify-for-jdk8
needs: verify-for-jdk11
runs-on: windows-latest

steps:
- uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'temurin'

- name: setup maven for sonatype snapshots
uses: whelk-io/maven-settings-xml-action@v20
with:
Expand Down Expand Up @@ -141,13 +155,14 @@ jobs:
shell: cmd
# ISSUE https://stackoverflow.com/questions/74581510/using-latest-for-archetypeversion-always-resolves-to-latest-release
# NOTE will use last released archetype
# TODO after 1.0.0 release should change DarchetypeVersion to LATEST
run: |
mvn archetype:generate ^
--batch-mode ^
-Dmaven.wagon.http.ssl.insecure=true ^
-DarchetypeGroupId=dev.aherscu.qa ^
-DarchetypeArtifactId=qa-testing-archetype ^
-DarchetypeVersion=LATEST ^
-DarchetypeVersion=1.0.0-SNAPSHOT ^
-DgroupId=com.acme ^
-DartifactId=testing ^
-Dversion=0.0.1-SNAPSHOT ^
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
java-version: '8'
java-version: '11'
distribution: 'temurin'
cache: maven
settings-path: ${{ github.workspace }}
Expand Down
3 changes: 2 additions & 1 deletion .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions .idea/runConfigurations/rebuild_commons.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .mvn/wrapper/maven-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.4/apache-maven-3.9.4-bin.zip
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.5/apache-maven-3.9.5-bin.zip
wrapperUrl =https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar
Loading
Loading