Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add correct indexing for SpinDensityNew output #4552

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

camelto2
Copy link
Contributor

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

small bugfix for spin density output to hdf5. Fixes #4533

Note: this only fixes the problem. Actual testing to catch bugs like this and a better design which doesn't rely on ObservableHelper will follow this up (see #4540)

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

M1 mac

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@camelto2 camelto2 changed the title add correct indexing add correct indexing for SpinDensityNew output Apr 12, 2023
@ye-luo
Copy link
Contributor

ye-luo commented Apr 12, 2023

Test this please

@ye-luo ye-luo enabled auto-merge April 12, 2023 19:28
@ye-luo ye-luo merged commit 9fe29de into QMCPACK:develop Apr 12, 2023
@camelto2 camelto2 deleted the spin_density_est_bug branch April 13, 2023 22:39
@prckent prckent mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spin density is incorrect in the batched driver port
2 participants