Make setTwist/twist take/return a const reference. #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Hahn <[email protected]>
markdewing
reviewed
Aug 31, 2023
| @@ -102,7 +102,8 @@ std::unique_ptr<TrialWaveFunction> WaveFunctionFactory::buildTWF(xmlNodePtr cur, | |||
| if (!foundtwist) | |||
| { | |||
| //default twist is [0 0 0] | |||
| std::vector<ParticleSet::RealType> tsts(3, 0); | |||
| tsts.resize(3); | |||
There was a problem hiding this comment.
tsts is size 3 in the declaration (and set to 0) in the declaration. Is there a need to set it again here?
There was a problem hiding this comment.
The original code where the declaration of 'tsts' occurs right before the use seems clear to me, but maybe I'm missing something?
There was a problem hiding this comment.
Except for the name. In isolation, I would read 'tsts' as 'tests'. Maybe it could be expanded to 'twists'?
There was a problem hiding this comment.
I updated the name and added a rvalue function overload to avoid the extra copy.
Signed-off-by: Steven Hahn <[email protected]>
markdewing
approved these changes
Aug 31, 2023
|
Test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.
Cleaning up a getter and setter that generate unnecessary copies. Functions were found during work on #4684.
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.